Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade ddprof to 0.57.0 #5475

Merged
merged 1 commit into from
Jun 27, 2023
Merged

upgrade ddprof to 0.57.0 #5475

merged 1 commit into from
Jun 27, 2023

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Jun 27, 2023 •
edited
Loading

What Does This Do

  • Safer JFR writer - protects buffer limits with unused memory, meaning overflows result in truncation, not heap corruption and subsequent segfault when the buffer is next written into
  • Ensures all constant pool strings are truncated correctly, which prevents buffer overflows

Motivation

Additional Notes

@richardstartin richardstartin requested a review from a team as a code owner June 27, 2023 13:23
@PerfectSlayer PerfectSlayer added the tag: dependencies Dependencies related changes label Jun 27, 2023
@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2023 •
edited
Loading

Benchmarks

Parameters

Baseline Candidate
commit 1.17.0-SNAPSHOT~6ebe8446e1 1.17.0-SNAPSHOT~5d549b8e42
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

@richardstartin richardstartin changed the title upgrade ddprof to 0.56.0 upgrade ddprof to 0.57.0 Jun 27, 2023
@richardstartin richardstartin removed the tag: dependencies Dependencies related changes label Jun 27, 2023
@richardstartin richardstartin merged commit 24ca69b into master Jun 27, 2023
@richardstartin richardstartin deleted the rgs/ddprof-0.56.0 branch June 27, 2023 16:30
@github-actions github-actions bot added this to the 1.17.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richardstartin @jbachorik @PerfectSlayer